Author Topic: TinyMenu 2.0.1 causes gContactSync AddressBook toolbar menu to disappear  (Read 1130 times)

tanstaafl

  • Global Moderator
  • Full Member
  • *****
  • Posts: 97
  • Karma: +0/-0
Hi Josh,

JI encountered a minor cosmetic bug/conflict with the TinyMenu 2.0.1 extension.

I reported it to the TinyMenu developer since it seems like it would be a problem with it than gContactSync, but I'm just reporting it here in case anyone else bumps into this - and in case the problem may be with gContactSync.

Bug summary: when TinyMenu 2.0.1 is installed, the gContactSync Address Book toolbar menu disappears. Uninstalling/Disabling TinyMenu brings the gContactSync menu back.


Josh Geenen

  • gContactSync Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 453
  • Karma: +1/-0
    • Pi Rules.org
Re: TinyMenu 2.0.1 causes gContactSync AddressBook toolbar menu to disappear
« Reply #1 on: October 02, 2009, 11:35:25 AM »
I encountered that problem when I installed that extension, too. This is the warning logged by gContactSync 0.2.8
Quote
***WARNING: Unable to setup the menu
Error Message:
[Exception... "Node was not found"  code: "8" nsresult: "0x80530008 (NS_ERROR_DOM_NOT_FOUND_ERR)"  location: "chrome://gcontactsync/content/Overlay.js Line: 266"]

gContactSync looks for the Tools menu ("tasksMenu") but cannot find it even though TinyMenu appears to keep the same ID for the menu.  This could probably be fixed on my end, so I'll leave a comment in your ticket after I've had more time to look at this.

Thanks for letting me know

Josh
gContactSync: info FAQs

Josh Geenen

  • gContactSync Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 453
  • Karma: +1/-0
    • Pi Rules.org
Re: TinyMenu 2.0.1 causes gContactSync AddressBook toolbar menu to disappear
« Reply #2 on: October 03, 2009, 07:18:51 AM »
I checked in a fix for 0.2 and 0.3 a few minutes ago.  I will probably release 0.2.9 within a week with that fix.

Did you want to fix the problem now or just wait until 0.2.9 is out?  It should only involve replacing a file in the extension folder or I can make a 0.2.8-r1 release with the fix that you can install like normal.

Bug 21840 has the details and patches.

Josh
gContactSync: info FAQs

tanstaafl

  • Global Moderator
  • Full Member
  • *****
  • Posts: 97
  • Karma: +0/-0
Re: TinyMenu 2.0.1 causes gContactSync AddressBook toolbar menu to disappear
« Reply #3 on: October 08, 2009, 08:08:21 AM »
Confirming that it fixes the missing menu in the single 'Menu' that TinyMenu replaces all of  the normal menu items with.

Thanks Josh!

But, I discovered something else - and again, I don't know if this is a TinymMenu or gContactSync issue...

When you open the Prefs for TinyMenu, the gContactSync menu doesn't show up in the appropriate Menu list - looks like it would be the last one. I'll go add a FR for TinyMenu to add a label for which Menu is for which window - if that is even possible - maybe not, since I would think the dev would have already done it if it was easy.

Anyway, thanks again for the quick fix Josh!

tanstaafl

  • Global Moderator
  • Full Member
  • *****
  • Posts: 97
  • Karma: +0/-0
Re: TinyMenu 2.0.1 causes gContactSync AddressBook toolbar menu to disappear
« Reply #4 on: February 26, 2010, 10:56:16 AM »
This bug is back with Tinymenu 2.0.2 - but I don't know if it was the new version of Tinymenu or one of the later version of gContactsync that caused the regression...

Josh Geenen

  • gContactSync Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 453
  • Karma: +1/-0
    • Pi Rules.org
The bug should be fixed in 0.2.13 - https://addons.mozilla.org/en-US/thunderbird/addon/8451
It should show up within a few hours.
gContactSync: info FAQs