Author Topic: [patch] Contact Photos: TypeError: card is null  (Read 527 times)

Kalten

  • Newbie
  • *
  • Posts: 1
  • Karma: +0/-0
[patch] Contact Photos: TypeError: card is null
« on: March 21, 2017, 05:29:33 AM »
Hello!

With some contacts I get an error-window such as this
using Contact Photos:
> Contact Photos Error:
> TypeError: card is null

After pressing ‹OK› the e-mail is opened.

One such (very short) contact is the following:

...8<---  some.vcf
BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.1.1//EN
UID:86fd7b24-831e-449e-970f-0cffbc76cf2f
N:Some;;;;
FN:Some
REV:20170316T113848Z
EMAIL;TYPE=x-newsletter:newsletter@some.com
X-THUNDERBIRD-ETAG:"f1c429c005cd6d0aa87e60a1a61e20e4"
END:VCARD
--->8...

I am using:
* contact_photos-0.1.12-sm+tb.xpi
* ThunderBird 45.8.0 (on FreeBSD)
* CardBook 17.8
* (and nextcloud as source)


I have patched content/mainOverlay.js (see Attachment)
to correct this error.

Pray do commit this change.
Regards,
 Kalten

Josh Geenen

  • gContactSync Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 720
  • Karma: +5/-0
    • Pi Rules.org
Re: [patch] Contact Photos: TypeError: card is null
« Reply #1 on: April 14, 2017, 08:44:18 AM »
Thanks for letting me know, I've uploaded v1.0.0 for review with the fix.

Josh
gContactSync: info FAQs

Grav

  • Newbie
  • *
  • Posts: 2
  • Karma: +0/-0
Re: [patch] Contact Photos: TypeError: card is null
« Reply #2 on: April 14, 2017, 11:10:47 AM »
This patch actually completely removes contact photos for me altogether.

The extension is still present and active, but the area where the photo used to be displayed is no longer present at all.

Worth mentioning is that I recently replaced SoGo Connector with CardBook to managing CardDAV contacts, and for whatever reason it doesn't use the native TB address books.

Grav

  • Newbie
  • *
  • Posts: 2
  • Karma: +0/-0
Re: [patch] Contact Photos: TypeError: card is null
« Reply #3 on: April 29, 2017, 10:41:33 AM »
The missing photos area cleared up for me. I think that was actually prior to the update.

With version 1.0.0 the "gFolderDisplay.displayedFolder is null" warning has returned.

That dialog actually appears twice now, the second instance shows up after acknowledging the first.

Ubuntu 14.04.5 LTS (amd64)
Thunderbird 53.0b2 (amd64)
CardBook 18.8
Contact Photos 1.0.0